From 0cb90634586acfad0b2446c767f3c250ff2e68d9 Mon Sep 17 00:00:00 2001 From: Hannes <13hannes11@gmail.com> Date: Fri, 10 Nov 2017 00:55:20 +0100 Subject: [PATCH] changed filesaving to use counter to prevent duplicate filename issues --- .../kuchelmeister/xkcd/downloader/ImageDownloader.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/xkcd_downloader/src/org/kuchelmeister/xkcd/downloader/ImageDownloader.java b/xkcd_downloader/src/org/kuchelmeister/xkcd/downloader/ImageDownloader.java index 11e61d3..244777e 100644 --- a/xkcd_downloader/src/org/kuchelmeister/xkcd/downloader/ImageDownloader.java +++ b/xkcd_downloader/src/org/kuchelmeister/xkcd/downloader/ImageDownloader.java @@ -16,9 +16,10 @@ public class ImageDownloader { downloadedImages = new LinkedList<>(); } - private void downloadImage(final String url, final String folderPath) throws IOException { + private void downloadImage(final String url, final String folderPath, final int counter) throws IOException { final InputStream in = new URL(url).openStream(); - final String fileName = url.substring(url.lastIndexOf("/")).replaceAll("[^A-Za-z0-9.]", ""); + final String fileName = "Comic_" + counter;// url.substring(url.lastIndexOf("/")).replaceAll("[^A-Za-z0-9.]", + // ""); downloadedImages.add(folderPath + fileName); @@ -28,9 +29,9 @@ public class ImageDownloader { } public void downloadAllImages(final List images, final String folderPath) { - for (final String img : images) { + for (int i = 0; i < images.size(); i++) { try { - this.downloadImage(img, folderPath); + this.downloadImage(images.get(i), folderPath, i); } catch (final IOException e) { e.printStackTrace(); return;